Skip to content

Conversation

krishnaGauss
Copy link
Contributor

Closes #11110

This PR adds a feature for showing an unclickable Private for lists by patrons who have Private accounts.

Technical

  • Added an else condition when patron account isn't public.

Testing

  • Click on any book.
  • Scroll down to Lists.
  • For private accounts one can now see an unclickable Private button.

Screenshot

image

Stakeholders

@ragipidavid

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (e027195) to head (8df2b43).
⚠️ Report is 415 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11113      +/-   ##
==========================================
+ Coverage   17.14%   17.85%   +0.71%     
==========================================
  Files          91       92       +1     
  Lines        4981     5096     +115     
  Branches      867      887      +20     
==========================================
+ Hits          854      910      +56     
- Misses       3588     3639      +51     
- Partials      539      547       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 7, 2025
@mekarpeles mekarpeles merged commit 90ad864 into internetarchive:master Aug 7, 2025
5 checks passed
@mekarpeles
Copy link
Member

Nice job @krishnaGauss, thank you

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show unclickable [Private] button when Follow unavailable

4 participants