add typehints to memcache_memoize #11092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #11003 (comment)
One of the things mentioned there was adding typed dicts. However, in some of the cases where I was trying I'd eventually run into the memoized functions that have no types.
I did a little research and learned that we can add typehints for memoized functions. And it turns out it works just fine to do so without much change.
The one change that is made here is removing the
_cache = 'delete'option.Basically, it's not possible to faithfully show the type of the function you're caching and allow for extra args.
Also, deleting manually is much better for separation of concerns. Besides, we only used that arg in a few places so it's not much to fix.
Technical
Testing
Screenshot
Stakeholders