Fix author page lists not loading #11086
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11086 +/- ##
==========================================
+ Coverage 17.14% 17.85% +0.70%
==========================================
Files 91 92 +1
Lines 4981 5097 +116
Branches 867 889 +22
==========================================
+ Hits 854 910 +56
- Misses 3588 3638 +50
- Partials 539 549 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdrini
reviewed
Jul 31, 2025
Comment on lines
+93
to
+95
| if (this.checkInComponents) { | ||
| this.checkInComponents.initialize() | ||
| } |
There was a problem hiding this comment.
This might be a good place for the JS optional chaining operator:
Suggested change
| if (this.checkInComponents) { | |
| this.checkInComponents.initialize() | |
| } | |
| this.checkInComponents?.initialize() |
cdrini
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Tested on https://testing.openlibrary.org/authors/OL15003393A/Dayeon_Auh and works like a charm! Merge at your discretion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11085
Addresses bug which prevents lists from loading on author and orphaned edition pages.
Technical
The My Books Droppers that are rendered on author page sidebars are not associated with a work ID (the same is true for droppers on orphaned edition pages). The HTML for the check-in components is not rendered for these droppers, as check-ins require a work ID.
Whenever
this.checkInComponents.initialize()was called by a dropper that didn't include the check-in HTML, it threw an exception that prevented theinitMyBooksAffordancesfunction from fetching the list data and updating the view.Now, if there is no check-in HTML included with a dropper, we set
this.checkInComponentstonulland check for the object before callinginitialize(). This null check is only needed here, as it is present in all other places wherethis.checkInComponentsis referenced.Testing
Screenshot
Stakeholders