Skip to content

Conversation

@RayBB
Copy link
Collaborator

@RayBB RayBB commented Jul 23, 2025

Noticed some dead code commented out that hasn't been touched for years.
Lets remove it?

https://github.com/internetarchive/openlibrary/blame/2bdaf7c22cfb04f8d54f278c9bf7e48f586adf75/openlibrary/components/MergeUI/utils.js#L269-L280

Technical

Testing

Screenshot

Stakeholders

@RayBB RayBB requested a review from cdrini July 23, 2025 03:37
@github-project-automation github-project-automation bot moved this to Waiting Review/Merge from Staff in Ray's Project Jul 23, 2025
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Good catch!

@cdrini cdrini merged commit 8131580 into master Jul 23, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting Review/Merge from Staff to Done in Ray's Project Jul 23, 2025
@cdrini cdrini deleted the fix/remove-dead-merge-code branch July 23, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants