Account anonymization POST handler
#11053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
commented
Jul 22, 2025
jimchamp
commented
Jul 22, 2025
243deab to
c1f5971
Compare
jimchamp
commented
Jul 23, 2025
fb4238a to
2a375e4
Compare
7c03a93 to
eab1ca6
Compare
jimchamp
commented
Jul 23, 2025
| # Fetch and anonymize account | ||
| xauthn_response = InternetArchiveAccount.s3auth(s3_access, s3_secret) | ||
| if 'error' in xauthn_response: | ||
| raise web.HTTPError("404 Not Found", {"Content-Type": "application/json"}) |
There was a problem hiding this comment.
A 404 isn't exactly an accurate status code for this case. This could fail for any number of reasons. How should we handle this?
Adds handling for a `test` query parameter. if `test` is "true", the account anonymization will not occur.
3fbfe9c to
123b1d4
Compare
f931ab8 to
423d546
Compare
for more information, see https://pre-commit.ci
mekarpeles
reviewed
Jul 24, 2025
|
|
||
| parsed_origin = urlparse(origin) | ||
| host = parsed_origin.hostname | ||
| return host == "archive.org" or host.endswith(".archive.org") |
There was a problem hiding this comment.
We might be safe enough with just "archive.org"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10976
Adds new
POSThandler that can be used to anonymize Open Library accounts via archive.org.POSTrequests to/account/anonymize.jsoncontaining validx-s3-accessandx-s3-secretheaders trigger an account anonymization action on the associated account.Technical
/account/anonymize.jsonresponses200 OK400 Bad Request403 Forbidden404 Not Found500 Internal Server ErrorAdding
?test=trueto account anonymization requests will trigger the account anonymization intestmode, which will prevent the account from actually being anonymized.Testing
Screenshot
Stakeholders