Update buildPartialsUrl for single /partials.json endpoint
#11042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the buildPartialsUrl function to standardize on a single /partials.json endpoint by replacing the path parameter with a component parameter and making params optional. The function now automatically sets the _component query parameter instead of requiring callers to include it manually.
- Simplified
buildPartialsUrlAPI by replacing path parameter with component parameter - Made params parameter optional with default empty object
- Updated all call sites to use the new API signature
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openlibrary/plugins/openlibrary/js/utils.js | Modified buildPartialsUrl function signature and implementation |
| openlibrary/plugins/openlibrary/js/search.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/lists/ListService.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/lazy-carousel.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/fulltext-search-suggestion.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/check-ins/index.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/carousel/Carousel.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/book-page-lists.js | Updated function call to use new API |
| openlibrary/plugins/openlibrary/js/affiliate-links.js | Updated function call to use new API |
cdrini
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11040
Closes #10984
Replaces the
buildPartialsUrlpathparameter withcomponent. Makesparamsoptional, for partials requests that require no query parameters (aside from_component).Technical
Testing
Screenshot
Stakeholders