Closes #10965; fix resolve redirect chain in export #11038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where redirect chains were not being properly resolved during export operations. The problem occurred when infogami returned a redirect type object instead of a hydrated Work object, causing the export to fail with Nothing being returned.
- Replaces the incorrect method call on the redirect object with proper static method usage
- Imports the
Workclass to access the correctresolve_redirect_chainmethod - Ensures the resolved work key is properly retrieved and used to fetch the actual work object
for more information, see https://pre-commit.ci
cdrini
approved these changes
Jul 18, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10965
Technical
The
workwe were getting back from infogami was actually a typeredirectand was not hydrated by the core.models.Work class (and returnedNothing).Stakeholders
@cdrini