fixes deploy mac and tag release #11017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues in the deployment script and adds new tag/release workflows.
- Defines
OL_REPOglobally and updates alltag_deploycalls to use it - Changes how the latest tag is determined and adds
tagandreleasesubcommands - Adjusts interactive prompts in
deploy_wizardfor more intuitive defaults
Comments suppressed due to low confidence (3)
scripts/deployment/deploy.sh:611
- The new
tagandreleasesubcommands should be documented in the script’s usage/help section so users know they are available.
elif [ "$1" == "tag" ]; then
scripts/deployment/deploy.sh:568
- The new conditional flow in
deploy_wizard(skipping deploy and optionally checking sync) isn't covered by automated tests. Consider refactoring for testability or adding tests for all interactive paths.
read -p "[Now] Run openlibrary deploy & audit now? [Y/n]..." answer
scripts/deployment/deploy.sh:406
- [nitpick] Removing the PID from the background-start message makes it harder to trace processes during debugging. Consider restoring the PID output for better visibility.
echo "(started in background)"
cdrini
reviewed
Jul 16, 2025
There was a problem hiding this comment.
One bug, and one spot where some duplicated code's been added. Merge at your discretion, I can't decide how problematic that bug is -- we might want to add at least a warning or a notice. I'm a bit tight on time today so can't fix these rn. We can unblock deploys by having Jim make the PID fix locally, that should fix the deploy if his version of bash also for some reason errors with the -1 index.
for more information, see https://pre-commit.ci
jimchamp
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11019
Fixes deploys
Technical
Testing
Screenshot
Stakeholders