Skip to content

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Jul 7, 2025

Closes #

Removes a few unused css that I cannot find used anywhere at all.
However, they could always be added by some string concat so good to have an extra review.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini requested a review from Copilot July 7, 2025 12:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up legacy and component CSS by removing selectors that appear unused across the codebase.

  • Removed orphaned rule sets from legacy.less tied to legacy templates
  • Deleted unused component styles in work.less and read-panel.less

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
static/css/legacy.less Stripped out multiple unused selectors/styles
static/css/components/work.less Removed unused .print-disabled-download and .patron-metadata rules
static/css/components/read-panel.less Deleted unused &-panel__print-disabled-download block

@RayBB RayBB force-pushed the remove-unused-css-july-2025 branch from f28996e to f8014e4 Compare July 8, 2025 04:02
@github-project-automation github-project-automation bot moved this to Waiting Review/Merge from Staff in Ray's Project Jul 23, 2025
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! It's been on testing for ~1w and haven't noticed any issues.

@cdrini cdrini merged commit 7918088 into master Jul 23, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting Review/Merge from Staff to Done in Ray's Project Jul 23, 2025
@cdrini cdrini deleted the remove-unused-css-july-2025 branch July 23, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants