Skip to content

Update glow to 0.12 and winit to 0.28. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rodrigorc
Copy link
Contributor

Glow 0.11 could not be used because GL resources changed from plain integers into new-types with a private inner value:

- type Texture = c_uint;
+ pub struct Texture(NonZeroU32);

That breaks many usages from imgui-rs. But in Glow 0.12 the inner value is pub so all is ok again:

+ pub struct Texture(pub NonZeroU32);

And since I'm into it, I'm updating winit, that has just been updated. Feel free to dissmiss this change or request it to be a separated PR (sorry in advance, I don't know the policy about dependency udpates).

@Rob2309
Copy link
Contributor

Rob2309 commented Mar 7, 2023

It seems like this would be a duplicate of #711.

@parasyte parasyte mentioned this pull request Mar 14, 2023
@dbr
Copy link
Contributor

dbr commented Mar 22, 2023

Yep I think this is covered by #711, and there is some complication currently with the winit update described in #716

Regardless, thank you for the PR! 😁

@dbr dbr closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants