Skip to content

Restoring "Include imgui/misc/freetype/ in crate package" from 0.8.x release #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

dbr
Copy link
Contributor

@dbr dbr commented Oct 5, 2022

In trying to straighten things out for #665 I noticed one of the bugfixes release in 0.8.something wasn't in the main branch - specifically the change for #595

This reapplies this fix to main branch, allowing the "--features freetype" to work when using via crates.io

Required for "--features freetype" to work when using via crates.io

Closes imgui-rs#594
Closes imgui-rs#589
@dbr
Copy link
Contributor Author

dbr commented Oct 5, 2022

Continuing the "everything ended up in a bit of a mess" story of 0.8's patch releases, this was fixed slightly differently in main in 9128066

However I think this PR is still worth merging as the glob patterns in 9128066 result in an unnecessarily huge .crate (as it includes copies of all the imgui C++ example backends and docs etc), whereas the this PR only includes the necessary files

@dbr dbr merged commit 4f3e6b0 into imgui-rs:main Nov 22, 2022
@dbr dbr deleted the freetypecratebugport branch November 22, 2022 06:30
@thomcc
Copy link
Member

thomcc commented Nov 22, 2022

In general we do "fork off and do a patch release" we should be sure to merge the changes back to main in some fashion after that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants