Skip to content

Remove im_str! usage from examples in docs #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Sejsel
Copy link
Contributor

@Sejsel Sejsel commented Feb 27, 2022

This removes leftover im_str! calls within examples in docs. I believe I got them all, the only remaining mentions of im_str are in the changelog and the macro definition itself.

Fixes #617.

@Sejsel
Copy link
Contributor Author

Sejsel commented Feb 27, 2022

The failed check is not caused by these changes, it's some kind of cmake failure.

@sanbox-irl
Copy link
Member

Thanks so much! And yeah, this looks related to github updated windows-latest so that it used VS2022

@sanbox-irl sanbox-irl merged commit 30f8f04 into imgui-rs:main Feb 28, 2022
@dbr
Copy link
Contributor

dbr commented Feb 28, 2022

And yeah, this looks related to github updated windows-latest so that it used VS2022

More specifically that the cache for the old windows-latest is reused for the new version, since the cache key is based on runner.os which is just "Windows". Surprisingly there doesn't seem to be a way to get a more specific OS-version string:

https://github.community/t/possible-to-get-specific-os-version-for-cache-keys/162282
actions/cache#543

Only workaround seems to be to specify the OS versions explicitly in the matrix: which isn't the worst thing, just something we'd need to occasionally remember to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider docs still reference im_str!
3 participants