Skip to content

Refactor Slider to work under new Ui-based architecture #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

Refactor Slider to work under new Ui-based architecture #607

merged 1 commit into from
Jan 28, 2022

Conversation

imlazyeye
Copy link
Contributor

Changes the API for creating a Slider from...

let mut state = 0;
Slider::new("label", 0, 1).build(ui, &mut state);

...into...

let mut state = 0;
ui.slider("label", 0, 1, &mut state);

...in order to match the rest of the new architecture!

@sanbox-irl sanbox-irl merged commit d058272 into imgui-rs:main Jan 28, 2022
@sanbox-irl
Copy link
Member

LGTM! Thank you @imlazyeye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imlazyeye @sanbox-irl