Fix igbinary_serialize incorrectly deduplicating arrays/objects #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6b0104 to
28de346
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 7, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] skip igbinary < 3.1.6 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38440 | License | MIT | Doc PR | - v3.1.6 will embed igbinary/igbinary#289 Commits ------- 065474c [Cache] skip igbinary < 3.1.6
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Oct 7, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] skip igbinary < 3.1.6 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38440 | License | MIT | Doc PR | - v3.1.6 will embed igbinary/igbinary#289 Commits ------- 065474c94f [Cache] skip igbinary < 3.1.6
19e36d0 to
ced56e3
Compare
…ects ... That are freed For example, this can be seen when `__serialize` returns an array that contains a temporary array. Before, because the result of `__serialize` was immediately freed, another array could be created with the exact same memory address, and igbinary would incorrectly assume they're duplicates. Incorrect deduplication can be avoided by keeping references to all serialized arrays/objects/references around in memory. This may affect the performance of serialization. Fixes igbinary#287 Based on igbinary#288
ced56e3 to
a81109f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... That are freed
For example, this can be seen when
__serializereturns an array thatcontains a temporary array.
Before, because the result of
__serializewas immediately freed,another array could be created with the exact same memory address,
and igbinary would incorrectly assume they're duplicates.
Incorrect deduplication can be avoided by keeping references to all
serialized arrays/objects around in memory.
TODO: Add additional checks/tests for references.(done)This may affect the performance of serialization.
Fixes #287
Based on #288