feat: Distinguish I-Ds on WG plate from I-Ds on IESG plate #9214
Conversation
|
We can define a sort that is not alphabetical with very little work. I think something like "Drafts with the IESG" would be a better heading. I don't think we currently can get into a position where we have a non- This will have enough impact that the PR should come with tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9214 +/- ##
=======================================
Coverage 88.86% 88.87%
=======================================
Files 319 319
Lines 41911 41917 +6
=======================================
+ Hits 37245 37252 +7
+ Misses 4666 4665 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I will finally have to dig in this part of the code ;-) |
Humm the plural filter won't work then :-( moreover there should then be a RFC Editor search_heading |
|
The plural decoration is really overkill for section headers like this - a section that has only one draft but with "drafts" in the section header isn't going damage the reader's comprehension. "With the RFC Editor" seems good too, but this looks like something that needs some design and definitely some tests to make sure we're doing the right thing with drafts of all provenance. |
|
shifting to draft while aspects discussed in-person are addressed. |
|
@rjsparks when you have time, you may want to review the extended test coverage. |
ietf/group/views.py
Outdated
| docs_related.append(d) | ||
| else: | ||
| if d.type_id == "draft" and d.stream_id == 'ietf' and d.get_state_slug('draft-iesg') != 'idexists': # values can be: ad-eval idexists approved rfcqueue dead iesg-eva | ||
| d.search_heading = "Internet-Draft at the IESG" |
There was a problem hiding this comment.
This should be "Internet-Drafts at the IESG" to parallel the other search headings
There was a problem hiding this comment.
I don't think it's quite that simple - the PR currently makes all the headings singular, but looking at the result, I agree we should move back towards being able to use the pluralizer. I'll see if I can propose a different approach.
There was a problem hiding this comment.
Indeed, @rjsparks and I had a discussion in Madrid about this topic. I do not mind either way though
There was a problem hiding this comment.
I pushed a fairly large change in, but it should be easy to follow: 385325a
Address #8783
Added a new search_heading with "Outside of the WG Internet-Draft" when IESG-state != idexists
Using "outside" will make the I-Ds outside of the WG plate be listed after "Active" and "Expired" but before "RFC"