Skip to content

Add ONNX export support for Chinese CLIP #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025
Merged

Add ONNX export support for Chinese CLIP #1591

merged 8 commits into from
Jun 11, 2025

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Dec 13, 2023

What does this PR do?

As title says. Should be good to go since it's just a clone of the CLIP exporter.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fxmarty
Copy link
Contributor

fxmarty commented Jan 26, 2024

@xenova Can you push to this branch so that the CI is rerun?

@xenova
Copy link
Contributor Author

xenova commented Jan 26, 2024

@fxmarty done ✅ (I just merged main)

Copy link

github-actions bot commented Feb 2, 2025

This PR has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 2, 2025
@github-actions github-actions bot closed this Mar 4, 2025
@xenova xenova reopened this Mar 4, 2025
@xenova xenova requested a review from echarlaix March 4, 2025 16:21
@github-actions github-actions bot removed the Stale label Mar 5, 2025
Copy link

github-actions bot commented Jun 3, 2025

This PR has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jun 3, 2025
@echarlaix echarlaix added the onnx Related to the ONNX export label Jun 4, 2025
@github-actions github-actions bot removed the Stale label Jun 5, 2025
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay @xenova !!! Completely missed it for some reasons. LGTM !

@echarlaix echarlaix merged commit 74f2345 into main Jun 11, 2025
32 of 34 checks passed
@echarlaix echarlaix deleted the add-chinese_clip branch June 11, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onnx Related to the ONNX export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants