Skip to content

[Modular] Consolidate load_default_components into load_components #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Aug 22, 2025

What does this PR do?

load_default_components is a thin wrapper around load_components and just deals with the case when name=None. IMO better to just consolidate it into load_components

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

]
self.load_components(names=names, **kwargs)
# Consolidated into load_components - just call it without names parameter
logger.warning("`load_default_components` is deprecated. Please use `load_components()` instead")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyixuxu Up to you whether we just remove the method all together or deprecate. Fine with either.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just remove!

@DN6 DN6 requested a review from yiyixuxu August 22, 2025 13:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

]
self.load_components(names=names, **kwargs)
# Consolidated into load_components - just call it without names parameter
logger.warning("`load_default_components` is deprecated. Please use `load_components()` instead")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just remove!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants