-
Notifications
You must be signed in to change notification settings - Fork 44
provide a definition for the close connection option under 1.1 tear-down #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for 'the close' being a bit weird (but I don't feel that strongly about it; suggestions for replacement inline).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except as noted by @mnot, the bare close strings look weird.
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Fixes #678