Skip to content

Conversation

@royfielding
Copy link
Member

Fixes #678

@royfielding royfielding requested review from mnot and reschke March 26, 2021 00:43
Copy link
Member

@mnot mnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for 'the close' being a bit weird (but I don't feel that strongly about it; suggestions for replacement inline).

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except as noted by @mnot, the bare close strings look weird.

royfielding and others added 3 commits March 26, 2021 09:05
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
@royfielding royfielding merged commit a2c8b97 into master Mar 26, 2021
@royfielding royfielding deleted the fielding-i678 branch March 26, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

close connection item lost its definition

3 participants