Skip to content

build(npm): ignore docs #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

build(npm): ignore docs #57

merged 1 commit into from
Jan 25, 2021

Conversation

crs48
Copy link
Member

@crs48 crs48 commented Jan 21, 2021 •
edited
Loading

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@crs48 crs48 added the documentation Improvements or additions to documentation label Jan 21, 2021
@crs48 crs48 requested a review from rubinovitz January 21, 2021 16:39
@crs48 crs48 self-assigned this Jan 21, 2021
rubinovitz
rubinovitz approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crs48 crs48 merged commit af9c355 into master Jan 25, 2021
@crs48 crs48 deleted the ignore-docs branch January 25, 2021 15:33
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This PR is included in version 0.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rubinovitz rubinovitz rubinovitz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@crs48 crs48

Labels
documentation Improvements or additions to documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crs48 @rubinovitz