Use EPOCHREALTIME in build_data timing logic #1881
Merged
+22
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built-in Bash (5.0+) variable, a float with microseconds precision. Faster, simpler, and more portable (no longer requires GNU date). Logging it with six digits worth of precision instead of the previous three, but a float is a float ;) (without a precision indicator, awk gives the usual hand-wavy float result of possibly a few more digits, we just discard that) GUS-W-19404492
c633034 to
022d606
Compare
edmorley
approved these changes
Aug 22, 2025
Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Since the `print` causes less precision, eg:
```
root@d4d36b9d6a56:/# awk -v start="${start_time}" -v end="${end_time}" 'BEGIN { print (end - start) }'
13.2063
```
So it would be better to either switch back to `printf`:
```
root@d4d36b9d6a56:/# awk -v start="${start_time}" -v end="${end_time}" 'BEGIN { printf "%f", (end - start) }'
13.206290
```
Or use `OFMT` with `print`:
```
root@d4d36b9d6a56:/# awk -v start="${start_time}" -v end="${end_time}" -v OFMT="%f" 'BEGIN { print (end - start) }'
13.206290
```
Given that we don't want the trailing newline (albeit the command substitution removes it for us), lets go with `printf` again (plus it saves people having to understand `OFMT`).
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Aug 22, 2025
Inspired by heroku/heroku-buildpack-python#1881. This works locally and on Heroku. It works in bash, but not zsh by default (have to `zmodload zsh/datetime` to get it to work). We're explicitly using bash in these scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-in Bash (5.0+) variable, a float with microseconds precision. Faster, simpler, and more portable (no longer requires GNU
date).GUS-W-19404492