Skip to content

Add tests for build metadata contents #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Add tests for build metadata contents #1877

merged 1 commit into from
Aug 20, 2025

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Aug 20, 2025

It's not possible to test bin/report functionality directly using Hatchet tests, however, we can dump the raw build metadata store values to at least test that we're storing the expected keys/values.

This complements the existing non-Hatchet container CI test that checks that bin/report exits zero.

This has been split out of the upcoming bin/report refactor PR to keep that PR smaller, and to more easily demonstrate the change in behaviour after that PR.

GUS-W-19384622.

It's not possible to test `bin/report` functionality directly using Hatchet
tests, however, we can dump the raw build metadata store values to at
least test that we're storing the expected keys/values.

This complements the non-Hatchet container CI test that checks that
`bin/report` exits zero.

This has been split out of the upcoming `bin/report` refactor PR to
keep that PR smaller, and to more easily demonstrate the change in
behaviour after that PR.

GUS-W-19384622.
@edmorley edmorley self-assigned this Aug 20, 2025
@edmorley edmorley marked this pull request as ready for review August 20, 2025 14:00
@edmorley edmorley requested a review from a team as a code owner August 20, 2025 14:00
@edmorley edmorley enabled auto-merge (squash) August 20, 2025 14:00
@edmorley edmorley merged commit 3c27de9 into main Aug 20, 2025
6 of 7 checks passed
@edmorley edmorley deleted the build-data-tests branch August 20, 2025 14:24
@heroku-linguist heroku-linguist bot mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants