Skip to content

Fix run-http cmd #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

Fix run-http cmd #132

merged 1 commit into from
Aug 12, 2025
+2 −2

Conversation

mayank-sisodiya
Copy link
Contributor

make build builds the binary to bin/ path. Configuring run-http paths to pick the right binary path.

[12/08/25 2:59:01] *[main][~/work/mcp/terraform-mcp-server]$ make run-http 
bin/terraform-mcp-server http --transport-port 8080 --transport-host 0.0.0.0
Command "http" is deprecated, Use 'streamable-http' instead
INFO[0000] Using endpoint path: /mcp                    
INFO[0000] Running in stateful mode (default)           
INFO[0000] CORS Mode: strict                            
WARN[0000] No allowed origins configured in strict mode. All cross-origin requests will be rejected. 
INFO[0000] Starting StreamableHTTP server on 0.0.0.0:8080/mcp 
^CINFO[0001] Shutting down StreamableHTTP server...

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@mayank-sisodiya mayank-sisodiya requested a review from a team as a code owner August 11, 2025 21:31
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Aug 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app HashiCorp CLA App
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

gautambaghel
gautambaghel approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@gautambaghel gautambaghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayank-sisodiya mayank-sisodiya merged commit b6228b7 into main Aug 12, 2025
31 checks passed
@mayank-sisodiya mayank-sisodiya deleted the fix/make_run-http branch August 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautambaghel gautambaghel gautambaghel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayank-sisodiya @gautambaghel