Skip to content

Possibility to run JMH benchmarks without JAR build #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

dfa1
Copy link
Contributor

@dfa1 dfa1 commented Jul 24, 2025

It is very handy to start a benchmark directly from within IntelliJ:
image

Without this configuration, I get the following error "Unable to find the resource: /META-INF/BenchmarkList"
@bbakerman @andimarek @dondonz

It is very handy to start a benchmark directly from
within IntelliJ.
@dondonz dondonz added this to the 25.x breaking changes milestone Jul 27, 2025
@dondonz
Copy link
Member

dondonz commented Jul 27, 2025

Thanks for reporting and fixing! Legend

@dondonz dondonz merged commit b09381d into graphql-java:master Jul 27, 2025
1 check passed
@bbakerman
Copy link
Member

Ahh this is a gradle secret source. I too also got this (while @andimarek didnt on his IDEA) and I could never work out why I could not run JMHs in IDEA any more ( I used to be able to)

Thanks

@andimarek
Copy link
Member

@dfa1 @bbakerman @dondonz sorry, but I don't think this is the right change: i explicitly removed the jmhAnnotationProcessor 'org.openjdk.jmh:jmh-generator-annprocess:1.37' to make the setup work without having continuous build errors.

@dfa1 @bbakerman you have the jmh idea plugin installed? With it you should be able to run it without any main/other setup.

@dfa1
Copy link
Contributor Author

dfa1 commented Jul 29, 2025

@andimarek hi, I tried with and without the JMH plugin. At work, we are using this setup with maven without any special plugin too and it works nicely with recent IDEA (2025.x)

@dondonz
Copy link
Member

dondonz commented Jul 29, 2025

I downloaded the JMH plugin, and got the same error as @dfa1 without this PR's change. When I checked out this PR, the problem went away

I didn't know about the build issue, let's check it out

@bbakerman
Copy link
Member

I also have the JMH plugin installed and I cant run them. I also tried it without the JMH plugin and I cant run them via main() either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants