[Test] Perf test dump #3954
[Test] Perf test dump #3954
Conversation
| @@ -1,6 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-bin.zip | |||
There was a problem hiding this comment.
Is there a particular reason for updating Gradle in this PR?
| @@ -54,4 +54,3 @@ jar { | |||
| ) | |||
There was a problem hiding this comment.
You can remove [Test] from the PR name to mark this as ready for review
|
|
||
| @Warmup(iterations = 2, time = 5) | ||
| @Measurement(iterations = 3, time = 10) | ||
| @Fork(3) |
There was a problem hiding this comment.
Something I will later add as an ArchUnit test, we usually have 2 forks in GraphQL Java JMH tests to keep the running time shorter
|
|
||
| @Warmup(iterations = 2, time = 5) | ||
| @Measurement(iterations = 3) | ||
| @Fork(3) |
There was a problem hiding this comment.
Could you change this to 2 forks please?
| @BenchmarkMode(Mode.AverageTime) | ||
| @Warmup(iterations = 2, time = 5) | ||
| @Measurement(iterations = 3) | ||
| @Fork(3) |
There was a problem hiding this comment.
Could you change this to 2 forks please?
| @BenchmarkMode(Mode.AverageTime) | ||
| @Warmup(iterations = 2, time = 5) | ||
| @Measurement(iterations = 3) | ||
| @Fork(3) |
There was a problem hiding this comment.
Also could you change this to 2?
| @BenchmarkMode(Mode.AverageTime) | ||
| @Warmup(iterations = 2, time = 5) | ||
| @Measurement(iterations = 3) | ||
| @Fork(3) |
There was a problem hiding this comment.
Also could you change this to 2?
There was a problem hiding this comment.
Something to look at after this PR is merged, it would be good to check how long these tests take to complete in the pipeline
I would like to keep the total test running time under 1 hour because it's running on every commit. If that's the case we can have a separate tier of tests that are run less frequently, for example on release milestones
No description provided.