Skip to content

Skipping crypto tests with expired certificate #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Skipping crypto tests with expired certificate #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions compiler/natives/src/crypto/tls/handshake_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

// Same as upstream, except we check for GOARCH=ecmascript instead of wasm.
// This override can be removed after https://github.com/golang/go/pull/51827
// is available in the upstream (likely in Go 1.19).
// is available in the upstream (likely after Go 1.19).
func TestServerHandshakeContextCancellation(t *testing.T) {
c, s := localPipe(t)
ctx, cancel := context.WithCancel(context.Background())
Expand Down Expand Up @@ -42,7 +42,7 @@ func TestServerHandshakeContextCancellation(t *testing.T) {

// Same as upstream, except we check for GOARCH=ecmascript instead of wasm.
// This override can be removed after https://github.com/golang/go/pull/51827
// is available in the upstream (likely in Go 1.19).
// is available in the upstream (likely after Go 1.19).
func TestClientHandshakeContextCancellation(t *testing.T) {
c, s := localPipe(t)
ctx, cancel := context.WithCancel(context.Background())
Expand Down Expand Up @@ -71,3 +71,15 @@ func TestClientHandshakeContextCancellation(t *testing.T) {
t.Error("Client connection was not closed when the context was canceled")
}
}

func TestVerifyConnection(t *testing.T) {
// This should be rechecked after upgrading to Go 1.20 or later.
// go1.19.13/src/crypto/tls/handshake_test.go:testRSACertificateIssuer has expired.
t.Skip("Skipping test that uses predefined certificate that expired in Jan 1st 2025")
}

func TestResumptionKeepsOCSPAndSCT(t *testing.T) {
// This should be rechecked after upgrading to Go 1.20 or later.
// go1.19.13/src/crypto/tls/handshake_test.go:testRSACertificateIssuer has expired.
t.Skip("Skipping test that uses predefined certificate that expired in Jan 1st 2025")
}
Loading