Fixing issue in len
with string concatenation in argument
#1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #841
I added a check to see if the expression used as the argument inside the
len
contains binary expressions. If a binary expression exists, then the expression is parenthesized. For example,len(a)
will still be translated toa.length
without the parenthesis.len(a +b)
was getting translated toa + b.lengh
(which was the problem), but now get translated into(a + b).length
with parenthesis. We don't want to add parenthesis all the time to avoid making the resulting JS larger when not needed.This will cover any combination of concatenations of variable and literal strings, e.g.
len(a + b)
,len(a + ":" + b)
. The issue exists only when a basic type is used inlen
, i.e.string
. I didn't limit the check to only being additions (+
) for concatenation of strings, even though no other binary operator applies to a string, to allow more robustness for future changes (e.g. if Go suddenly decides to be more like python and add-
and*
as operators allowed to use on strings). This work does not need to be carried over tocap
sincecap
is not valid for strings.