update Dockerfile.DS to solve series type convertion bugs in kniren/gota #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone with more Docker expertise than me can please review this? |
sbinet
reviewed
Jan 6, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM alpine:3.5 | |||
| FROM alpine:3.14 | |||
| && go get -insecure gonum.org/v1/plot/... \ | ||
| && go get -insecure gonum.org/v1/gonum/... \ | ||
| && go get github.com/kniren/gota/... \ | ||
| && export GOINSECURE=gonum.org/v1/plot/...,gonum.org/v1/gonum/...,go-hep.org/x/hep/csvutil/...,go-hep.org/x/hep/fit,go-hep.org/x/hep/hbook \ |
Comment on lines
38
to
39
| ### fix pyzmq to v16.0.2 as that is what is distributed with py3-zmq | ||
| ### pin down the tornado and ipykernel to compatible versions |
There was a problem hiding this comment.
perhaps remove these historical comments?
Comment on lines
+12
to
+13
| --repository http://dl-4.alpinelinux.org/alpine/v3.14/community \ | ||
| --repository http://dl-4.alpinelinux.org/alpine/v3.14/main \ |
| python3-dev \ | ||
| mesa-dev \ | ||
| && pip3 install --upgrade pip==21.3.1 \ | ||
| && cp /usr/bin/python3.9 /usr/bin/python \ | ||
| ## install Go | ||
| && apk --update-cache --allow-untrusted \ | ||
| --repository http://dl-4.alpinelinux.org/alpine/edge/community \ |
There was a problem hiding this comment.
I don't think this is needed anymore (with >=3.14).
ditto for the --allow-untrusted argument above.
Closed
|
ping? |
|
superceded by #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in Issue #201 , the bug is in the docker container for data science, when we try to convert some columns' data types, it shows
reflect.Value.Convert: value of type reflect.Value cannot be converted to type series.Type.We identified that the bug is from the go package
kniren/gota. But the packagego-gota/gotacan work well. So I modified the Dockerfile.DS to replacekniren/gotawithgo-gota/gota.Also, I updated the Alpine image version and some pre-installed packages and software which solves the cyclic imports error in issue #233 .