fix: test_blob_acl_w_metageneration_match due to Public access prevention #1526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: test_blob_acl_w_metageneration_match
google.com
org. Hence predefined roles such asallUsers
andallAuthenticatedUsers
cannot be used for system tests.test_blob_acl_w_metageneration_match
is to test whether the library is able to set blob's acl with and without metageneration match. Hence instead of save_predefined, created a new acl (READER) for "google.com" domain asserted acl.save with / without metageneration matchtest_blob_acl_upload_predefined
we need predefined acl . We've 7 predefined ACLs - https://cloud.google.com/storage/docs/access-control/lists#predefined-aclBottom three in the list would make the access public,
projectPrivate
is default. I chosedprivate
out of the remaining 3 (private
,bucketOwnerRead
,bucketOwnerFullControl
) as I faced issues in bucketOwnerRead (this would've been ideal)Fixes #1521
Fixes #1520