Skip to content

fix: test_blob_acl_w_metageneration_match due to Public access prevention #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chandra-siri
Copy link
Contributor

@chandra-siri chandra-siri commented Aug 20, 2025

fix: test_blob_acl_w_metageneration_match

  • Public access prevention has been enforced on buckets under google.com org. Hence predefined roles such as allUsers and allAuthenticatedUsers cannot be used for system tests.
  • Since the intention of the test test_blob_acl_w_metageneration_match is to test whether the library is able to set blob's acl with and without metageneration match. Hence instead of save_predefined, created a new acl (READER) for "google.com" domain asserted acl.save with / without metageneration match
  • For test_blob_acl_upload_predefined we need predefined acl . We've 7 predefined ACLs - https://cloud.google.com/storage/docs/access-control/lists#predefined-acl
    Bottom three in the list would make the access public, projectPrivate is default. I chosed private out of the remaining 3 (private, bucketOwnerRead, bucketOwnerFullControl) as I faced issues in bucketOwnerRead (this would've been ideal)

Fixes #1521
Fixes #1520

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Aug 20, 2025
@chandra-siri chandra-siri changed the title fix test_blob_acl_w_metageneration_match chore: integration tests fixes test_blob_acl_w_metageneration_match Aug 20, 2025
@chandra-siri chandra-siri changed the title chore: integration tests fixes test_blob_acl_w_metageneration_match fix: test_blob_acl_w_metageneration_match Aug 20, 2025
@chandra-siri chandra-siri force-pushed the fix/1521/failing_blob_acl_test branch from d17931b to 690db41 Compare August 20, 2025 17:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 20, 2025
@chandra-siri chandra-siri added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 20, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 20, 2025
@chandra-siri chandra-siri marked this pull request as ready for review August 20, 2025 18:51
@chandra-siri chandra-siri requested review from a team as code owners August 20, 2025 18:51
@chandra-siri chandra-siri changed the title fix: test_blob_acl_w_metageneration_match fix: test_blob_acl_w_metageneration_match due to Public access prevention Aug 20, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 20, 2025
@chandra-siri chandra-siri added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2025
@chandra-siri chandra-siri merged commit 7ce4e0b into googleapis:main Aug 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.system.test_blob: test_blob_acl_upload_predefined failed tests.system.test_blob: test_blob_acl_w_metageneration_match failed
3 participants