Skip to content

ci: Mark the prerelease presubmit check as optional #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

ci: Mark the prerelease presubmit check as optional #164

merged 1 commit into from
Dec 5, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 5, 2022

unittest-prerelease / unit (3.10) appears as a required check on presubmits. I believe that is because unit (3.10) is a required check under Github Settings. I think we need to rename unit to unit-prerelease in .github/workflows/unittest-prerelease.yml so that it is not part of the unit (3.10) required check.

@parthea parthea requested a review from a team as a code owner December 5, 2022 18:22
@parthea parthea requested review from a team and alvarowolfx December 5, 2022 18:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Dec 5, 2022
tswast
tswast approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast enabled auto-merge (squash) December 5, 2022 18:24
@tswast tswast merged commit 7876c6b into main Dec 5, 2022
@tswast tswast deleted the parthea-patch-1 branch December 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @tswast