Skip to content

chore: Cleanup kokoro artifacts at end of build #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

chore: Cleanup kokoro artifacts at end of build #1462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445dad7
chore: Cleanup kokoro artifacts at end of build
TrevorBergeron Mar 6, 2025
d6cbc33
Merge branch 'main' into clean_build_artifacts
TrevorBergeron Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@ if [[ -n "${NOX_SESSION:-}" ]]; then
else
python3 -m nox --stop-on-first-error
fi

# Prevent kokoro from trying to collect many mb of artifacts, wasting several minutes
sudo rm -rf "${KOKORO_ARTIFACTS_DIR?}"/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this might break the release build. Could you check?

Also, I recall there is a https://github.com/googleapis/repo-automation-bots/tree/main/packages/flakybot that could use these to automatically file issues for which specific tests are being flaky. It was in the list of TODOs when we first setup the repo, but I don't think we ever got around to setting it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, release build uses release.sh for its build file. Flakybot seems to be independent of post-build artifact collection, and is only invoked from samples tests it seems.