Skip to content

chore: keep gemini code commented out in the notebook template #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

chore: keep gemini code commented out in the notebook template #1314

merged 2 commits into from
Jan 23, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jan 22, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 391484838 🦕

@shobsi shobsi requested review from a team as code owners January 22, 2025 23:50
@shobsi shobsi requested a review from shuoweil January 22, 2025 23:50
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 22, 2025
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 22, 2025
@shobsi shobsi changed the title chore: keep Gemini code commented out in the notebook template chore: keep gemini code commented out in the notebook template Jan 22, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jan 23, 2025
@shobsi shobsi merged commit d941a84 into main Jan 23, 2025
22 checks passed
@shobsi shobsi deleted the shobs-nb-comment-out-gemini branch January 23, 2025 06:43
shuoweil pushed a commit that referenced this pull request Jan 23, 2025
@shobsi @shuoweil
chore: keep gemini code commented out in the notebook template (#1314)
8b251e7 
* Keep Gemini code commented out in the notebook template

* disable progress bar to avoid leaking internal information
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
@shobsi @shuoweil
chore: keep gemini code commented out in the notebook template (#1314)
1cdb0f4 
* Keep Gemini code commented out in the notebook template

* disable progress bar to avoid leaking internal information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaxunwu jiaxunwu jiaxunwu approved these changes

@shuoweil shuoweil Awaiting requested review from shuoweil shuoweil is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @jiaxunwu @chelsea-lin