Skip to content

Error reporting: fixed mistake in documentation #8271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2019
Merged

Error reporting: fixed mistake in documentation #8271

merged 1 commit into from
Jun 11, 2019

Conversation

j-flat
Copy link
Contributor

@j-flat j-flat commented Jun 10, 2019

Fixing mistake in documentation regarding issue: #8270.

Changed code examples on chapter:Reporting an error without an exception to call report() method of the instance of Client-class, instead of method within error_reporting module.

@j-flat j-flat requested a review from busunkim96 as a code owner June 10, 2019 12:04
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 10, 2019
@j-flat j-flat mentioned this pull request Jun 10, 2019
Closed
@busunkim96
Copy link
Contributor

Hi @j-flat, thank you for the PR! Would you mind signing the CLA?

@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Jun 10, 2019
@j-flat
Copy link
Contributor Author

j-flat commented Jun 11, 2019

Hi @busunkim96 , I had signed it previously, but it userd my company email. I have now signed it with my personal gmail as well, email that is connected with my github user :)

@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 11, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96 busunkim96 merged commit c6532d0 into googleapis:master Jun 11, 2019
@busunkim96
Copy link
Contributor

I did a manual search for a CLA for j-flat and found two associated with the GitHub username.

@j-flat j-flat deleted the 8270-error-reporting-documentation-has-incorrect-code-examples branch June 11, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-flat @googlebot @busunkim96 @tseaver