Skip to content

Monitoring: pick up fixes to the GAPIC generator. #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/monitoring/artman_monitoring.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/monitoring-v3.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/group_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/uptime_check_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/notification_channel_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/metric_service_client.py.
synthtool > Replaced 'def .*\\(([^\\)]+)\n.*metadata=None\\):\n\\s+"""(.*\n)*?\\s+"""\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/monitoring_v3/proto/common_pb2.py.
synthtool > No replacements made in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py for pattern then a new `\[CONDITION_ID\]` is created.
, maybe replacement is not longer needed?
synthtool > Replaced '                ::\n\n' in google/cloud/monitoring_v3/gapic/alert_policy_service_client.py.
synthtool > Replaced '^(\\s+)have an ``id`` label:  ::      resource.type =\n.*' in google/cloud/monitoring_v3/proto/metric_service_pb2.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/monitoring_v3/gapic/transports/metric_service_grpc_transport.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/monitoring_v3/gapic/transports/group_service_grpc_transport.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/monitoring_v3/gapic/transports/notification_channel_service_grpc_transport.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/monitoring_v3/gapic/transports/uptime_check_service_grpc_transport.py.
synthtool > Replaced 'return google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address,\n\\s+credentials=.*,\n\\s+scopes=.*,\n' in google/cloud/monitoring_v3/gapic/transports/alert_policy_service_grpc_transport.py.
synthtool > Replaced 'from google.cloud.monitoring_v3.gapic import notification_channel_service_client\n' in google/cloud/monitoring_v3/__init__.py.
synthtool > Replaced 'notification_channel_service_client.NotificationChannelServiceClient' in google/cloud/monitoring_v3/__init__.py.
synthtool > Cleaned up 1 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added api: monitoring Issues related to the Cloud Monitoring API. codegen labels Nov 19, 2018
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these PRs:

googleapis/gapic-generator#2407
googleapis/gapic-generator#2396

Unfortunately, the enum-order-instability problem still exists.

@tseaver tseaver changed the title [CHANGE ME] Re-generated monitoring to pick up changes in the API or client library generator. Monitoring: pick up fixes to the GAPIC generator. Nov 19, 2018
@tseaver tseaver merged commit a93fada into master Nov 19, 2018
@tseaver tseaver deleted the autosynth-monitoring branch November 19, 2018 16:07
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants