Skip to content

[DO NOT MERGE] Logging: order of enums only synth #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Logging: order of enums only synth #6474

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/logging/artman_logging.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:229601142daed005bf56fbaa21a02cf7aa0b261b57677d38306f8013e536de7a
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/logging-v2.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_config_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_metrics_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/log_entry_pb2.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated logging to pick up changes in the API or client library generator. [DO NOT MERGE] Logging: order of enums only synth Nov 12, 2018
@tseaver tseaver mentioned this pull request Nov 12, 2018
Closed
tseaver
tseaver reviewed Nov 12, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes here are spurious, due to googleapis/gapic-generator#2319

@tseaver tseaver added codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: logging Issues related to the Cloud Logging API. labels Nov 12, 2018
@tseaver tseaver mentioned this pull request Nov 21, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 21, 2018

Superseded by #6631.

tseaver added a commit that referenced this pull request Nov 21, 2018
@tseaver
Logging: pick up fixes to GAPIC generator. (#6631)
463a21e 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

Includes changes to generated tests.

Closes #6474.
@tseaver tseaver deleted the autosynth-logging branch November 21, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshi-automation @tseaver @googlebot