Skip to content

feat!: update release level to stable #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 12, 2025

BEGIN_COMMIT_OVERRIDE
feat: update release level to stable
feat!: set google.shopping.merchant_notifications_v1 as the default import for google.shopping.merchant_notifications

Release-As: 1.0.0
END_COMMIT_OVERRIDE

@parthea parthea requested a review from a team as a code owner August 12, 2025 16:09
@parthea parthea requested a review from vchudnov-g August 12, 2025 17:51
"proto-plus >= 1.22.3, <2.0.0",
"proto-plus >= 1.25.0, <2.0.0; python_version >= '3.13'",
"protobuf>=3.20.2,<7.0.0,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
"google-shopping-type >= 0.1.6, <1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving everything to be stable 1.0.0+, we still want this to be pinned to a pre-stable version?

google-api-core==1.34.1
google-auth==2.14.1
proto-plus==1.22.3
google-shopping-type==0.1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question: we don't want things pinned to a stable version of shopping?

@vchudnov-g
Copy link
Contributor

Do not merge yet until we regenerate this PR to depend on a stable version of google-shopping-type. See this comment.

@vchudnov-g vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants