feat: Support Enum parameter parsing in function declarations #625 #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0534c39 to
206a95b
Compare
|
@hangfei updated branch with main. It is my first PR to this project, please tell if I need to do anything else |
|
@lucasnobre212 could you resolve the conflicts? @seanzhou1023 Could you help review this change? Thanks. |
996403b to
9b27e49
Compare
|
I can't see any conflicts though. I just rebased my branch onto main and force pushed to update it |
Added handling for Enum types in `function_parameter_parse_util.py` to enable parsing of Enum parameters. Updated schema generation to include enum values and validated default values. Included a unit test to ensure correctness of the implementation.
9b27e49 to
40dab01
Compare
|
@lucasnobre212 Could you fix the formatting? |
|
@hangfei I already fixed the formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(My past PR (#625) was using the main branch in my fork and this was causing me problems. I created a new branch for this feature only. Sorry! )
Added handling for Enum types in function_parameter_parse_util.py to enable parsing of Enum parameters.
Updated schema generation to include enum values and validated default values.
Included a unit test to ensure correctness of the implementation.
Observations:
This is my first PR, so please tell me if I need to provide more context or make more changes
I added a unit test for Enum. I couldn't run a integration test though, I tried to run only test_single_function_calls_success from test_tools.py but pytest kept skipping it.
Closes #398
Testing plan:
Run
uv run pytest ./tests/unittestsMore specifically, you need to run the test test_enum_input in tests/unittests/tools/test_build_function_declaration.py