feat: support custom service account to adk deploy cloud_run
#2699
Conversation
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
There was a problem hiding this comment.
Summary of Changes
Hello @zchee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the capability to specify a custom service account when deploying applications to Google Cloud Run using the adk deploy cloud_run command. This enhancement allows users to deploy services with specific identity and access management permissions, moving beyond the default service account.
Highlights
- New Parameter: The
to_cloud_runfunction now accepts an optionalservice_accountparameter, allowing users to specify a custom service account for their Cloud Run deployments. - Deployment Integration: The provided
service_accountis now correctly passed as an argument to the underlyinggcloud run deploycommand, ensuring the specified service account is used during deployment. - Test Coverage: An existing unit test (
test_to_cloud_run_happy_path) has been updated to include validation for the newservice_accountparameter, ensuring its correct integration and functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Response from ADK Triaging Agent Hello @zchee, thank you for creating this PR! To help us review this feature addition, could you please create and associate a GitHub issue with this PR? Additionally, could you please provide the console output from running the This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Code Review
This pull request correctly implements the logic to support a custom service account for adk deploy cloud_run by adding a service_account parameter to the to_cloud_run function and updating the unit tests. However, the new feature is not exposed through the CLI. The cli_deploy_cloud_run function in src/google/adk/cli/cli_tools_click.py must be updated to include a --service_account option and pass its value to to_cloud_run. Without this, the feature is unusable. This is a critical issue that needs to be fixed.
| @@ -263,6 +263,7 @@ def test_to_cloud_run_happy_path( | |||
| region="asia-northeast1", | |||
| service_name="svc", | |||
| app_name="agent", | |||
| service_account="test@test.iam.gserviceaccount.com", | |||
There was a problem hiding this comment.
While this test covers the happy path where a service account is provided, it would be beneficial to also test the case where service_account is None. This would ensure the --service-account flag is not added to the gcloud command when no service account is specified. Consider parameterizing this test to cover both scenarios.
Summary
Add the
service_accountfield toto_cloud_runfor the ability to specify a non-default service account when deploying to Cloud Run.Related Issue
Closes #2700.
Testing Plan
Add
service_accountvalidation totest_to_cloud_run_happy_path.