Skip to content

py: Support __len__ of rangetype. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2018
Merged

py: Support __len__ of rangetype. #40

merged 1 commit into from
Dec 26, 2018

Conversation

corona10
Copy link
Collaborator

Fixes: #39

@corona10 corona10 requested a review from ncw December 24, 2018 15:47
@codecov-io
Copy link

codecov-io commented Dec 24, 2018 •
edited
Loading

Codecov Report

Merging #40 into master will increase coverage by 0.46%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage   65.24%   65.7%   +0.46%     
=========================================
  Files          56      56              
  Lines       10150   10170      +20     
=========================================
+ Hits         6622    6682      +60     
+ Misses       3066    3019      -47     
- Partials      462     469       +7
Impacted Files Coverage Δ
py/range.go 75% <84.61%> (+75%) ⬆️
py/arithmetic.go 61.69% <0%> (+1.11%) ⬆️
py/list.go 10.05% <0%> (+1.18%) ⬆️
py/function.go 25.95% <0%> (+1.52%) ⬆️
py/sequence.go 23.65% <0%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...dafaabf. Read the comment docs.

@corona10
Copy link
Collaborator Author

@ncw PTAL

@corona10 corona10 mentioned this pull request Dec 24, 2018
Closed
ncw
ncw approved these changes Dec 26, 2018
View reviewed changes
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thank you :-)

@ncw ncw merged commit 82240ed into go-python:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @codecov-io @ncw