Remove explicit empty "" handling in ConfigParser
#2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConfigParser has supported this for a long time, but it is now done redundantly since gitpython-developers#2035. This adds a test for it, both to make clearer that it is intended to work and to allow verifying that it continues to hold once the legacy special-casing for it is removed.
"" handling in ConfigParser"" handling in ConfigParser
Because literal `""` is a special case of `"..."` as parsed since gitpython-developers#2035.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the benefits of #2035 is that it automatically handles a quoted empty value, i.e.
name = "", correctly. Previously, this was handled as a special case, so that it would work even though other quoted values did not work (#1923). Since #2035, it is not necessary to handle it specially. Accordingly, this PR:""(4ebe407).