Skip to content

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented Jun 7, 2025

Two new test cases:

  • Unquoted, where extra whitespace is at the edges of what can be parsed as the value.
  • Quoted, where extra whitespace is next to but outside of the quotes.

The case where the whitespace is at the edges of the quoted value and inside the quotes, and thus part of the value, is already covered in #2036. That is merely renamed here, to distinguish it.

In both the:

- Unquoted case, where extra whitespace is at the edges of what can
  be parsed as the value.

- Quoted case, where extra whitespace is next to but outside of the
  quotes.

The case where the whitespace is at the edges of the quoted value
and *inside* the quotes, and thus part of the value, is already
covered in gitpython-developers#2036. (That is merely renamed here, to distinguish it.)
@EliahKagan EliahKagan force-pushed the config-whitespace branch from dd23f11 to e5a2db5 Compare June 7, 2025 23:44
@EliahKagan EliahKagan marked this pull request as ready for review June 7, 2025 23:54
@EliahKagan EliahKagan merged commit 63160de into gitpython-developers:main Jun 7, 2025
27 checks passed
@EliahKagan EliahKagan deleted the config-whitespace branch June 7, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant