Drop 3.6, increase type strictness #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasium
reviewed
Aug 3, 2021
doc/source/intro.rst
Outdated
| * `Git`_ 1.7.0 or newer | ||
| It should also work with older versions, but it may be that some operations | ||
| involving remotes will not work as expected. | ||
| * `GitDB`_ - a pure python git database implementation | ||
| * `typing_extensions`_ >= 3.10.0 |
There was a problem hiding this comment.
According to requirements.txt this should be "typing-extensions>=3.7.4.3;python_version<"3.10""
kasium
reviewed
Aug 3, 2021
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9" | ||
| "Programming Language :: Python :: 3.10" |
There was a problem hiding this comment.
You can also add "Typing :: Typed"
There was a problem hiding this comment.
Good idea, added it, and fixed intro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop 3.6, per discussion.
Add some mypy configs to increase strictness
Type fixes for stricter config.
Replace some Any types with the runtime results from tests
Try out
__future__.annotationsand|union syntaxReady for next release I think, except needs to be tested against 3.7.0 or 3.7.1 on linux
(I'm on Windows atm, so tests are dodgy).