Skip to content

Add more types #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2021
Merged

Add more types #1202

merged 4 commits into from
Mar 17, 2021

Conversation

Yobmod
Copy link
Contributor

@Yobmod Yobmod commented Mar 16, 2021 •
edited
Loading

Added types to:

git.init.py,
compat.py,
db.py,
diff.py,
exc.py,
util.py

Passes mypy and pyright checks

Also some suggested fixes from #1192

@Yobmod Yobmod mentioned this pull request Mar 16, 2021
Merged
Byron
Byron approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot for your perseverance!

@Byron Byron merged commit 6643a9f into gitpython-developers:master Mar 17, 2021
@jmcgill298 jmcgill298 mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yobmod @Byron