do not merge: testing CI 🤞 #39973
do not merge: testing CI 🤞 #39973
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
There was a problem hiding this comment.
Pull Request Overview
This PR is a test of the CI system and makes Node.js version and configuration updates across multiple files. The changes are focused on loosening Node.js version constraints and adding environment configuration.
- Updates Node.js version requirements to allow newer patch versions
- Removes specific Node.js version pinning in Docker builds
- Adds workaround for Node.js experimental strip-types feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Simplifies Node.js engine requirement from specific version range to allow all v22 versions |
| Dockerfile | Removes pinned Node.js version installation, allowing latest available version |
| .github/actions/node-npm-setup/action.yml | Adds environment variable to disable experimental strip-types feature |
| @@ -328,7 +328,7 @@ | |||
| "esm": "^3.2.25" | |||
| }, | |||
| "engines": { | |||
| "node": "^20 || >=22.0.0 <22.18.0" | |||
| "node": "^20 || ^22" | |||
There was a problem hiding this comment.
[nitpick] The Node.js version constraint has been loosened from a specific upper bound to allow all v22 versions. Consider if this change could introduce compatibility issues with newer Node.js versions that haven't been tested. The original constraint ^20 || >=22.0.0 <22.18.0 provided more predictable behavior by excluding untested versions.
| "node": "^20 || ^22" | |
| "node": "^20 || >=22.0.0 <22.18.0" |
Copilot uses AI. Check for mistakes.
| @@ -18,7 +18,7 @@ FROM ghcr.io/github/gh-base-image/gh-base-noble:20250805-204228-g50c20871f AS ba | |||
| # Must run as root | |||
| RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git \ | |||
| && curl -sL https://deb.nodesource.com/setup_22.x | bash - \ | |||
| && apt-get install -y nodejs=22.17.0-1nodesource1 \ | |||
| && apt-get install -y nodejs \ | |||
There was a problem hiding this comment.
Removing the specific Node.js version pin (nodejs=22.17.0-1nodesource1) could lead to non-reproducible builds as different versions may be installed depending on when the image is built. Consider pinning to a specific version or version range to ensure consistent builds across environments.
| && apt-get install -y nodejs \ | |
| && apt-get install -y nodejs=22.17.0-1nodesource1 \ |
Copilot uses AI. Check for mistakes.
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
just testing CI don't mind me 🧛