Add extra Customizations files #20252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Customizations.qll files to three languages (Swift, Rust, and C++) that previously lacked them, following the established pattern used in other CodeQL language packs. The customizations infrastructure allows users to extend the standard library with their own models and customizations.
- Adds new Customizations.qll files for Swift, Rust, and C++
- Updates the main language pack files to import the new Customizations modules
- Provides consistent infrastructure across languages for user-defined customizations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swift/ql/lib/swift.qll | Adds import statement for Customizations module |
| swift/ql/lib/Customizations.qll | Creates new customizations file with documentation and swift import |
| rust/ql/lib/rust.qll | Adds import statement for Customizations module |
| rust/ql/lib/Customizations.qll | Creates new customizations file with documentation and rust import |
| cpp/ql/lib/cpp.qll | Adds import statement for Customizations module |
| cpp/ql/lib/Customizations.qll | Creates new customizations file with documentation and cpp import |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
jketema
reviewed
Aug 20, 2025
jketema
reviewed
Aug 20, 2025
There was a problem hiding this comment.
LGTM. Could you add three library change notes though (one for each language). See https://github.com/github/codeql/blob/main/docs/change-notes.md
…b.com/knewbury01/codeql into knewbury01/add-uniform-Customizations
jketema
approved these changes
Aug 20, 2025
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for languages that do not have a Customizations file, add one