Skip to content

[flutter_migrate] Export as library #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[flutter_migrate] Export as library #3065

wants to merge 8 commits into from

Conversation

GaryQian
Copy link
Contributor

Export classes so that migrate can be used programmatically as a dart package. Also cleans up unused dependencies and removes version restrictions.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GaryQian GaryQian changed the title Migrateexport [flutter_migrate] Export as library Jan 18, 2023
christopherfujino
christopherfujino reviewed Jan 18, 2023
View reviewed changes
packages/flutter_migrate/lib/flutter_migrate.dart Outdated
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

/// A library to render markdown formatted text.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not the right dartdoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Will clean up :)

christopherfujino
christopherfujino approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about dartdoc, otherwise LGTM

@GaryQian GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 18, 2023

auto label is removed for flutter/packages, pr: 3065, due to - The status or check suite analyze CHANNEL:stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@GaryQian GaryQian mentioned this pull request Jan 19, 2023
Closed
@stuartmorgan-g stuartmorgan-g removed their request for review February 27, 2023 15:26
@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 9, 2023
Closed
@stuartmorgan-g
Copy link
Contributor

Closing; filed flutter/flutter#122306 with a breadcrumb back to this PR for when flutter_migrate is revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
needs tests p: flutter_migrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaryQian @stuartmorgan-g @reidbaker @christopherfujino