Skip to content

[ Tool ] Roll DWDS to fix ExistingDartDevelopmentServiceException #174306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Aug 22, 2025

Fixes #171758

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@bkonyi bkonyi requested a review from matanlurey August 22, 2025 19:51
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dwds dependency from version 24.4.0 to 24.4.0+1 in packages/flutter_tools/pubspec.yaml. This is a standard dependency roll intended to fix an ExistingDartDevelopmentServiceException. The change is straightforward and correct. I have no further feedback as there are no issues of medium or higher severity.

@bkonyi
Copy link
Contributor Author

bkonyi commented Aug 22, 2025

This change should be cherry picked as #171758 is a top-10 tool crasher.

@bkonyi bkonyi added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Aug 22, 2025
@matanlurey
Copy link
Contributor

Failing presubmits are a release-branch regression I'm attempting to fix in flutter/cocoon#4844.

auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Aug 22, 2025
…ngine (#4844)

I believe this will fix cases such as flutter/flutter#174306 where:

(a) The engine is not touched
(b) We expect the `flutter` tool to resolve an engine for us, i.e. using a content-aware hash
@matanlurey
Copy link
Contributor

matanlurey commented Aug 22, 2025

Trying a re-run with the new Cocoon build.

FPEV is now omitted:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/108889/infra

My hope is that flutter now picks up the engine via the content-aware hash and everything else swims along.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025
@auto-submit auto-submit bot merged commit 1a6b80d into flutter-3.35-candidate.0 Aug 22, 2025
146 checks passed
@auto-submit auto-submit bot deleted the fix_issue_171758 branch August 22, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants