-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[ Tool ] Roll DWDS to fix ExistingDartDevelopmentServiceException
#174306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the dwds
dependency from version 24.4.0
to 24.4.0+1
in packages/flutter_tools/pubspec.yaml
. This is a standard dependency roll intended to fix an ExistingDartDevelopmentServiceException
. The change is straightforward and correct. I have no further feedback as there are no issues of medium or higher severity.
This change should be cherry picked as #171758 is a top-10 tool crasher. |
Failing presubmits are a release-branch regression I'm attempting to fix in flutter/cocoon#4844. |
…ngine (#4844) I believe this will fix cases such as flutter/flutter#174306 where: (a) The engine is not touched (b) We expect the `flutter` tool to resolve an engine for us, i.e. using a content-aware hash
Trying a re-run with the new Cocoon build. FPEV is now omitted: My hope is that |
Fixes #171758