[ Tool ] Don't emit artifact downloading messages when --machine is provided #174301
+57
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where artifact download messages were being emitted when the --machine flag was provided, which is intended for machine-readable output. The change broadens the detection of the --machine flag to apply to any command, not just run and attach. A comprehensive regression test has been added to ensure that these human-readable download messages are suppressed in machine mode, preventing future regressions. The changes are well-implemented and the test is robust.
matanlurey
approved these changes
Aug 22, 2025
| final bool runMachine = | ||
| (args.contains('--machine') && args.contains('run')) || | ||
| (args.contains('--machine') && args.contains('attach')); | ||
| final bool runMachine = args.contains('--machine'); |
There was a problem hiding this comment.
Right? I don't even know why we'd want to limit this if we have multiple commands that support --machine and we create the logger factory here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154119