Make sure that a SimpleDialog doesn't crash in 0x0 environment #174229
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that a SimpleDialog does not crash when rendered in a zero-sized area. The test is a good addition to prevent future regressions. I have one minor suggestion to fix a typo in the test description.
| @@ -3021,6 +3021,14 @@ void main() { | |||
| expect(find.byType(BackButton), findsNothing); | |||
| expect(find.byType(CloseButton), findsOneWidget); | |||
| }); | |||
|
|
|||
| testWidgets("SimpleDialog doens't crash at zero area", (WidgetTester tester) async { | |||
There was a problem hiding this comment.
There's a small typo in the test description. "doens't" should be "doesn't".
Suggested change
| testWidgets("SimpleDialog doens't crash at zero area", (WidgetTester tester) async { | |
| testWidgets("SimpleDialog doesn't crash at zero area", (WidgetTester tester) async { |
3eb9f53 to
ccbeae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the SimpleDialog UI control.