Skip to content

[CP-stable][ios][tools] do not print out bonjour key not found in non-verbose mode #174182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: flutter-3.35-candidate.0
Choose a base branch
from

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Aug 21, 2025

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#172627

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

Do not print out NSBonjourService key not found error in non-verbose mode.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Without the fix, it would show the error message to all flutter apps when building on macOS 26.

Workaround:

Is there a workaround for this issue?

Manually add the key in Info.plist

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Run flutter build ios on macOS 26.

I have manually verified that it worked on both macOS 26 and older 15.6

…de (flutter#174001)

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This tries flutter#173569 again

That PR was reverted, because I didn't know that `streamOutput` was the
one used during non-verbose mode

The logging logic is a bit convoluted, see:
flutter#173887


So this PR simply changes the condition from

```
if (!verbose && exitCode == 0)
```

To 

```
if (!verbose && exitCode == 0 && !skipErrorLog)
```

So that if we skipErrorLog (will be true for bonjour features), it
doesn't call `streamOutput`.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

Fixes flutter#172627

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutteractionsbot flutteractionsbot requested a review from a team as a code owner August 21, 2025 04:33
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Aug 21, 2025
@flutteractionsbot
Copy link
Author

@hellohuanlin please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Aug 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a skipErrorLog option to the runSync method in xcode_backend.dart. This is used to prevent plutil from printing "key not found" errors when not in verbose mode, which could be confusing for users. The implementation correctly adds the new flag and updates calls to runSync for plutil. The unit and integration tests are also updated to verify this new behavior under both verbose and non-verbose conditions. The changes are logical and well-tested.

@hellohuanlin
Copy link
Contributor

@jtmcdole is the failure related to the content hashing work?

@matanlurey
Copy link
Contributor

Failing presubmits are a release-branch regression I'm attempting to fix in flutter/cocoon#4844.

@matanlurey
Copy link
Contributor

Trying a re-run with the new Cocoon build.

FPEV is now omitted:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/108889/infra

My hope is that flutter now picks up the engine via the content-aware hash and everything else swims along.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025
@matanlurey matanlurey force-pushed the cp-stable-70aea543b32e44bf736bb2f88a2cd05c2b68febd branch from a68e57e to 8705817 Compare August 22, 2025 20:35
Copy link
Contributor

auto-submit bot commented Aug 22, 2025

autosubmit label was removed for flutter/flutter/174182, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp: review Cherry-picks in the review queue team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants