Reapply "Add set semantics enabled API and wire iOS a11y bridge" #174163
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new API, PlatformDispatcher.setSemanticsTreeEnabled, to allow the framework to control when the semantics tree is generated and sent to the engine. This change refactors the semantics enabling logic, particularly for iOS, by moving the creation of the AccessibilityBridge to be controlled by this new API. The changes are well-tested with new unit and integration tests. My feedback is minor, focusing on a small documentation clarification to improve API clarity.
| /// may dispose any resources associated with processing semantics as no further | ||
| /// semantics updates will be sent via [FlutterView.updateSemantics]. | ||
| /// | ||
| /// One must call this method with true before sending update through [updateSemantics]. |
There was a problem hiding this comment.
The documentation for setSemanticsTreeEnabled refers to [updateSemantics]. This is ambiguous as it could refer to the deprecated PlatformDispatcher.updateSemantics or FlutterView.updateSemantics. To improve clarity and guide developers to the correct API, it would be better to explicitly mention [FlutterView.updateSemantics].
/// One must call this method with true before sending update through [FlutterView.updateSemantics].24bc279 to
c7e0c54
Compare
…a11y bridge (#161… (flutter#171198)" (flutter#174153)" This reverts commit 960d107.
c7e0c54 to
00788e2
Compare
Previous pr is reverted due to internal test failure
This is a straight reland, no change from previous. only need to migrate internal code
fixes #158399
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.